You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
33 lines
1.1 KiB
33 lines
1.1 KiB
4 years ago
|
## Grading
|
||
|
|
|
||
|
|
Core Tests: 59/59
|
||
|
|
|
||
|
|
Extra: 21/21
|
||
|
|
|
||
|
|
=========================
|
||
|
|
|
||
|
|
Standard tests: 80/80
|
||
|
|
|
||
|
|
Work Log: 10/10
|
||
|
|
|
||
|
|
Additional Tests: 10/10
|
||
|
|
|
||
|
|
Code style: 10/10
|
||
|
|
|
||
|
|
Improvements: +1
|
||
|
|
|
||
|
|
Overall: 111/110
|
||
|
|
|
||
|
|
Congratulations! Your analyzer has solved every test case correctly again. Your improvement is solid and easy to verify. The two-passes design is clear and direct.
|
||
|
|
|
||
|
|
## Testing
|
||
|
|
|
||
|
|
The additional test cases provided in the `student_contributed` directory are carefully selected and well structured. I am surprised that you managed to reproduce those error messages from reference-implementation. Some of them are weird and probably not worth reproducing, but thanks for reducing the workload on my end.
|
||
|
|
|
||
|
|
## Miscellaneous
|
||
|
|
The Code structure is clear and consistent but could still be improved by removing commented codes (at least in the final version).
|
||
|
|
|
||
|
|
The automatic test shell scripts are very helpful. It would be even better if you could organize them with CI tools like travis.ci or gitflow. It is totally optional but it would be fun to construct a CI pipeline.
|
||
|
|
|
||
|
|
The worklog contains some typos that could be avoided by adding a spellchecker to the IDE or CI.
|