From 5bcf48ffe4b226ab3c706f4cf9534b921270ece9 Mon Sep 17 00:00:00 2001 From: Sanjar Ahmadov Date: Tue, 23 Mar 2021 19:47:45 -0400 Subject: [PATCH] Cleanup --- grade.md | 41 ------------------- .../java/chocopy/pa2/StudentAnalysis.java | 2 +- 2 files changed, 1 insertion(+), 42 deletions(-) delete mode 100644 grade.md diff --git a/grade.md b/grade.md deleted file mode 100644 index 465d3ff..0000000 --- a/grade.md +++ /dev/null @@ -1,41 +0,0 @@ -# Grading - -Core Tests: 66/66 - -Extra: -- graph.py 5/5 -- mergesort.py 5/5 -- nesting.py 4/4 - -========================= - -Standard tests: 80/80 - -Work Log: 10/10 - -Additional Tests: 10/10 - -Code style: 10/10 - -Improvements: +3 - -Overall: 113/110 - - -# Parsing - -Your parser passed all tests, including the hidden ones, congratulations! Nice catch on the multiline string, which is a missing piece in the ChocoPy specification. Looking forward to your next project. - -# Testing - -Good work in the challenging cases in `good.py` like nested functions and class methods, and in `bad.py` like statements in class definition. - -It looks like you haven't added your own tests besides those in `good.py` and `bad.py`. We recommend pinning down more of your functionality with short, targeted tests in the future. - -# Process - -We generally recommend using pull requests over directly pushing into the master branch, especially when you want to work in parallel. As the project becomes more complex, you may appreciate the benefits of a more structured SDLC process. - -# Code - -Your code is clean and readable, with consistent naming convention and proper amount of comments. Well done. diff --git a/src/main/java/chocopy/pa2/StudentAnalysis.java b/src/main/java/chocopy/pa2/StudentAnalysis.java index d4c553d..cb90b58 100644 --- a/src/main/java/chocopy/pa2/StudentAnalysis.java +++ b/src/main/java/chocopy/pa2/StudentAnalysis.java @@ -90,7 +90,7 @@ public class StudentAnalysis { TypeChecker typeChecker = new TypeChecker(globalSym, program.errors); program.dispatch(typeChecker); } - System.out.println(program); + //System.out.println(program); return program; } }